Good Morning/Evening.

I applied all post review comments.
Feedback is much welcomed.

Thanks in advance
Bartosz

-----Original Message-----
From: Brad King [mailto:brad.k...@kitware.com] 
Sent: Friday, November 20, 2015 3:17 PM
To: Bartosz Kosiorek
Cc: cmake-developers@cmake.org; Gregor Jasny
Subject: Re: [cmake-developers] [PATCH] Fix Resource directory structure for 
iOS Bundles (Framework and Application), and update documentation

On 11/18/2015 11:05 AM, Bartosz Kosiorek wrote:
> With this simple patch in attachment I would like to do two things:

Thanks for working on this.  Here are some comments on the documentation.

> +This property may be set to a list of files to be placed in the 
> +corresponding  directory (eg. ``Resources`` directory for OS X) 
> +inside the bundle.  On non-Apple

Please wrap long lines.

> +Following example of Application Bundle:
> +::
> +  add_executable(ExecutableTarget
> +    addDemo.c
> +    resourcefile.txt
> +    appresourcedir/appres.txt
> +  )

CMake code examples should use the `.. code-block:: cmake` directive.

> +  set_target_properties(ExecutableTarget PROPERTIES
> +    MACOSX_BUNDLE TRUE
> +    MACOSX_FRAMEWORK_IDENTIFIER org.cmake.ExecutableTarget
> +    RESOURCE "${RESOURCE_FILES}"
> +  )
> +::

In reStructuredText syntax there is no trailing `::` in code blocks.

> +
> +will produce flat structure for iOS systems:
> +::
> +  ExecutableTarget.app
> +    appres.txt
> +    ExecutableTarget
> +    Info.plist
> +    resourcefile.txt
> +::

This can be written like this:

 will produce flat structure for iOS systems::

   ExecutableTarget.app
     appres.txt
     ExecutableTarget
     Info.plist
     resourcefile.txt

> \ No newline at end of file

Please add a trailing newline.

> Please let me know what do you think about that patch implementation.

Good start.  Please also extend the Tests/RunCMake/Framework test 
FrameworkLayout case to cover such resource files.

Thanks,
-Brad

Attachment: 0001-Fix-resource-directory-structure-update-help-and-tes.patch
Description: 0001-Fix-resource-directory-structure-update-help-and-tes.patch

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to