Am Dienstag, 19. Januar 2016, 14:25:15 schrieb Brad King: > On 09/09/2015 11:01 AM, Brad King wrote: > > FindwxWidgets: allow specifying required version > > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6089fde5 > > This introduced a regression reported here: > > https://cmake.org/Bug/view.php?id=15928 > > The version extraction from the header is breaking the reported case. > > > + find_file(_filename wx/version.h PATHS ${wxWidgets_INCLUDE_DIRS} > > NO_DEFAULT_PATH) > This call is affected by CMAKE_FIND_ROOT_PATH. Please take a look.
A random collection of thoughts I have on this: -"_filename" is a bad name for something that is find_* set in any module. Really. Since the value is also in the cache with older CMake releases I think this name is also used at another place, so here is not searched at all or so. -reading with file(STRINGS) will put much less stuff in the list that is REGEX REPLACEd later, which is probably much more efficient (depending on how large the file is) -maybe call to find_file can be omitted at all, and instead just FOREACH loop over the include dirs and simply if(EXISTS) check if the header is there Eike
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
