On 06/07/2016 10:42 AM, Tobias Hunger wrote: > On Mo, 2016-06-06 at 13:24 -0400, Brad King wrote: >> We should be able to refactor things to share the flags computation. >> Methods like >> >> cmLocalGenerator::GetTargetFlags > > Does this patch here make sense: > > https://github.com/hunger/CMake/commit/124f8295bee0c228b79a5cf38f0b2581be308118 > > It passes the configuration to GetTargetFlags instead of forcing it to the > build > type. Since I may end up with different configurations in the project > structure, > I think this is necessary.
Yes. Previously that method was only called in single-configuration generators so it could look up the CMAKE_BUILD_TYPE directly. In multi-config generators that variable is meaningless and instead they iterate over CMAKE_CONFIGURATION_TYPES. When you have a few such independent refactoring changes done we can look at integrating them immediately to avoid holding them externally in your daemon topic for too long. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
