On 06/08/2016 04:05 AM, Stephen Kelly wrote: > I have rebased it and force pushed my github branch (there are a few > rebasing mistakes which I'll remove later).
Thanks. > We hit issues at work that different clang-format versions have > different behavior. There we have the luxury of providing particular > binaries that every developer uses to get identical results and no diff > confusion. > > I don't know how to solve that in CMake though. It could become an issue > in the future when some contributors use clang-3.9 and others 3.8. Maybe > clang-format binaries should be in the repo. Right now we're using clang-format 3.8. We'll worry about such differences when they become a problem. > Also, it seems that clang-format is not run by CI. The ProductBuild > stuff doesn't seem to be clang formatted. Yeah, we haven't gotten that set up yet. Yesterday I added a topic to 'next' to fix that formatting. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
