Using the patchfile support I managed to implement the service installation issue I had, so the unnecessary features from the last patch are removed now.
I tested all patches separately and hope they work now. looking forward for feedback, best regrads, Michael > -----Original Message----- > From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] > On Behalf Of Stuermer, Michael SP/HZA-ZSEP > Sent: Wednesday, July 20, 2016 12:55 PM > To: Nils Gladitz; CMake Developers > Subject: Re: [cmake-developers] Improved WIX support > > > -----Original Message----- > > From: Nils Gladitz [mailto:nilsglad...@gmail.com] > > Sent: Wednesday, July 20, 2016 12:03 PM > > To: Stuermer, Michael SP/HZA-ZSEP; CMake Developers > > Subject: Re: [cmake-developers] Improved WIX support > > > > On 19.07.2016 17:43, Stuermer, Michael SP/HZA-ZSEP wrote: > > > Hello there, > > > > > > in short: > > > > > > I fixed some minor issues with WIX toolset support and added the > > possibility to integrate service installation/uninstallation with > > generated msi packages. Please review and comment what is missing for > > integration in upstream. > > > > > > a bit longer: > > > > > > When creating a component-based installer, the root component (or > > feature, as it is called in WIX context) cannot be named and > > described. This can now be done using > > CPACK_WIX_ROOT_COMPONENT_DISPLAY_NAME > > and CPACK_WIX_ROOT_COMPONENT_DESCRIPTION. > > > > > > The install folder can only be set to a subfolder of ProgramFiles or > > ProgramFiles64. With the option CPACK_WIX_SKIP_PROGRAM_FOLDER it > is > > now possible to set default installation paths on arbitrary locations > > such as "C:\myprogram". In order for this to work, the Guids of the > > WIX- Components must be explicitly set using > > CPACK_WIX_GENERATE_COMPONENT_GUIDS. Per default the Guids are > auto > > generated using the value "*". > > > > > > Disabling components by default using the > > CPACK_COMPONENT_<component_name>_DISABLED is now working. > > > > > > With the install file properties CPACK_WIX_KEYPATH and > > CPACK_WIX_PROPERTY_<tagname> it is now possible to add custom tags > > (such as service handling) to the installer. If the custom tag depends > > on several files within the directory, bundling of several files in > > WIX- Components is needed. This can be done using > > CPACK_WIX_BUNDLE_COMPONENTS. > > > > > > All new functionalities are documented and some small example > > > snippets > > are added to the documentation. > > > > > > I hope these changes make sense to you, if the documentation is not > > > accurate enough or the naming of cmake properties/variables should > > > be changed please let me know > > > > Would you mind dividing these changes into feature sized patches that > > I can review, test and integrate individually? > > > > I hoped I could avoid this :-). Of course I can split it up. > > Another thing: I just found out that I broke the patch-concept of the WIX > generator and that using a patchfile supports adding service installation and > handling. So I will remove the unnecessary features I added before > submitting the splitted patches. Will take a little time. > > > Thanks! > > Nils > > Best Regards > > Michael > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: http://cmake.org/cmake/help/support.html > CMake Consulting: http://cmake.org/cmake/help/consulting.html > CMake Training Courses: http://cmake.org/cmake/help/training.html > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/cmake-developers
0003-added-support-for.patch
Description: 0003-added-support-for.patch
0004-added-support-for-CPACK_WIX_SKIP_PROGRAM_FOLDER-to-e.patch
Description: 0004-added-support-for-CPACK_WIX_SKIP_PROGRAM_FOLDER-to-e.patch
0005-added-support-for-patching-feature-components-i.e.-a.patch
Description: 0005-added-support-for-patching-feature-components-i.e.-a.patch
0001-find-installed-files-also-if-they-are-prefixed-with-.patch
Description: 0001-find-installed-files-also-if-they-are-prefixed-with-.patch
0002-disabling-installer-components-for-WIX-now-working.patch
Description: 0002-disabling-installer-components-for-WIX-now-working.patch
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
