I've tried to implement it in the same way as CCMake seem to do it. Because I can't compare it => Could somone with access to ccmake test this: - Start CCMake with -D foo=123 - Configure - Question: Is foo displayed in the variable list? - Add/Edit foo to some other value - Configure - Question: Was foo overwritten with "123"?
Thanks On Fri, Nov 1, 2013 at 7:02 PM, Matthew Woehlke <[email protected] > wrote: > On 2013-11-01 11:39, physhh . wrote: > >> that's interesting. I'm currently at a windows only machine so i can't >> check out ccmake but can only lookup the source. It appears that ALL >> parameters get "forwarded" to cmake - at least that's what >> >> cmCursesMainForm.cxx:52 >> >>> this->CMakeInstance->SetArgs(**this->Args); >>> >> >> looks to me. >> Why do you think that a simple forward is not enough? ccmake seems to do >> it >> exactly that way? >> > > I don't know enough of the guts to know how values initially specified in > ccmake / cmake-gui get passed to CMake. Where you could get into trouble > is, say, you pass -DBOOST_ROOT=/some/ptah, realize you've made a mistake > (e.g. 'ptah' -> 'path') and fix it in the gui before running cmake. Now > does cmake see the original value or the corrected value? > > That's where it *might* go sideways. But it might also be perfectly safe > to just pass them through, e.g. if the corrected value is passed also as a > -D argument later in the list. > > However, what I was mainly getting at is that cmake-gui should also > process the -D, etc., as I am pretty sure ccmake does, so that it can > display those values and/or make appropriate use of the arguments. > > > -- > Matthew > > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/**CMake_FAQ<http://www.cmake.org/Wiki/CMake_FAQ> > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: > http://cmake.org/cmake/help/**support.html<http://cmake.org/cmake/help/support.html> > CMake Consulting: > http://cmake.org/cmake/help/**consulting.html<http://cmake.org/cmake/help/consulting.html> > CMake Training Courses: > http://cmake.org/cmake/help/**training.html<http://cmake.org/cmake/help/training.html> > > Visit other Kitware open-source projects at http://www.kitware.com/** > opensource/opensource.html<http://www.kitware.com/opensource/opensource.html> > > Follow this link to subscribe/unsubscribe: > http://www.cmake.org/mailman/**listinfo/cmake<http://www.cmake.org/mailman/listinfo/cmake> >
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
