On Mon, Feb 27, 2017 at 9:39 PM, Brad King <brad.k...@kitware.com> wrote: > On 02/27/2017 03:54 PM, Ray Donnelly wrote: >> This is why my PR asks the linker that the compiler will use for the >> actual list of implicit link dirs. I'm sorry I've not had time to >> write up a clear explanation yet. > > IIUC your case is the opposite of that under discussion in the rest > of this thread. You want to include a rpath that is not currently > included. Jörg wants to exclude a rpath that is currently being > incorrectly included. The detection you're proposing would not > discover the lib32 entry that is causing Jörg's problem. >
Not really, my PR is about ensuring that CMake's idea of implicit dirs isn't mismatched with the linker's actual implicit dirs by actually asking the linker. AFAICT, it fixes Jörg's problem too. I say that because as stated: > CMake passes the host rpath to the linker CMake does this because it isn't *asking* the linker, it's making assumptions instead (and adding some predefined values like `/usr/lib32`). If we just ask the linker instead then everything should work just fine (I am ignore linkers that cannot tell us here like Apple's ld64. I'm not sure how to tackle that one yet). > As I requested in your MR [1] it will be more appropriate to discuss > your rpath-inclusion use case in a separate issue. > > Thanks, > -Brad > > [1] https://gitlab.kitware.com/cmake/cmake/merge_requests/207#note_189880 > -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
