Anderson Silva wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I hope this patch will actually work. Please, ignore any of my previous
> patches, which should be easy enough since it didn't work to begin with.
>
> If this patch doesn't work, I might be doing something wrong with git,
> and help will be appreciated.
>
> AS
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
>
> iD8DBQFI0AIoECmX3C4JWKgRApx2AJ9F9jgDmghc+3Vaj/5/WjpYHsTZGACdEHVK
> OhHFkm4AmpBHbLir1cb6ck0=
> =h3/N
> -----END PGP SIGNATURE-----
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> cobbler mailing list
> [email protected]
> https://fedorahosted.org/mailman/listinfo/cobbler

I have noticed some problems with this though it is looking better.

I had to remove "ReportFunction" from cli_misc which might have been 
because the patch did not apply cleanly.

Also, the following command reports some rather strange output, 
generating four tables when I have four system records (some have 
multiple interfaces) instead of just one table

[EMAIL PROTECTED] cobbler]# cobbler report --what=systems --type=mediawiki 
--fields=name,netboot_enabled
{| border="1"
|name||netboot_enabled
|-
|S1||True
|-
|}

{| border="1"
|name||netboot_enabled
|-
|S1||True
|-
|drwily.rdu.redhat.com||True
|-
|}

{| border="1"
|name||netboot_enabled
|-
|S1||True
|-
|drwily.rdu.redhat.com||True
|-
|foo||True
|-
|}

{| border="1"
|name||netboot_enabled
|-
|S1||True
|-
|drwily.rdu.redhat.com||True
|-
|foo||True
|-
|unused_name||True
|-
|}

For comparision, here is the regular report output:

[EMAIL PROTECTED] cobbler]# cobbler system report
system                : S1
profile               : P1
image                 : None
kernel options        : {}
kernel options post   : {}
kickstart             : <<inherit>>
ks metadata           : {}
mgmt classes          : []
netboot enabled?      : True
owners                : ['admin']
server                : <<inherit>>
virt cpus             : <<inherit>>
virt file size        : <<inherit>>
virt path             : <<inherit>>
virt ram              : <<inherit>>
virt type             : <<inherit>>
interface        : intf0
  mac address    : BB:EE:EE:EE:EE:FF
  ip address     :
  hostname       :
  gateway        :
  subnet         :
  virt bridge    :
  dhcp tag       :
  is static?     : False

system                : drwily.rdu.redhat.com
profile               : testprofile0
image                 : None
kernel options        : {}
kernel options post   : {}
kickstart             : <<inherit>>
ks metadata           : {}
mgmt classes          : []
netboot enabled?      : True
owners                : ['admin']
server                : <<inherit>>
virt cpus             : <<inherit>>
virt file size        : <<inherit>>
virt path             : <<inherit>>
virt ram              : <<inherit>>
virt type             : <<inherit>>
interface        : intf0
  mac address    : BB:EE:EE:EE:EE:FF
  ip address     : 192.51.51.50
  hostname       :
  gateway        :
  subnet         :
  virt bridge    :
  dhcp tag       :
  is static?     : False

system                : foo
profile               : P1
image                 : None
kernel options        : {}
kernel options post   : {}
kickstart             : <<inherit>>
ks metadata           : {}
mgmt classes          : []
netboot enabled?      : True
owners                : ['admin']
server                : <<inherit>>
virt cpus             : <<inherit>>
virt file size        : <<inherit>>
virt path             : <<inherit>>
virt ram              : <<inherit>>
virt type             : <<inherit>>
interface        : intf0
  mac address    : AA:BB:CC:DD:EE:FF
  ip address     : 192.168.0.1
  hostname       : blip1
  gateway        :
  subnet         :
  virt bridge    :
  dhcp tag       :
  is static?     : False
interface        : intf1
  mac address    : AA:BB:CC:DD:EE:FE
  ip address     : 192.168.0.2
  hostname       : blip2
  gateway        :
  subnet         :
  virt bridge    :
  dhcp tag       :
  is static?     : True
interface        : intf2
  mac address    : AA:BB:CC:DD:EE:FE
  ip address     : 192.168.0.2
  hostname       : blip3
  gateway        : 192.168.0.10
  subnet         : 255.255.255.0
  virt bridge    :
  dhcp tag       :
  is static?     : True

system                : unused_name
profile               : testprofile0
image                 : None
kernel options        : {}
kernel options post   : {}
kickstart             : <<inherit>>
ks metadata           : {}
mgmt classes          : []
netboot enabled?      : True
owners                : ['admin']
server                : <<inherit>>
virt cpus             : <<inherit>>
virt file size        : <<inherit>>
virt path             : <<inherit>>
virt ram              : <<inherit>>
virt type             : <<inherit>>
interface        : intf0
  mac address    :
  ip address     :
  hostname       :
  gateway        :
  subnet         :
  virt bridge    :
  dhcp tag       :
  is static?     : False
interface        : intf3
  mac address    : AE:BE:DE:CE:AE:EE
  ip address     :
  hostname       :
  gateway        :
  subnet         :
  virt bridge    :
  dhcp tag       :
  is static?     : False
interface        : intf6
  mac address    :
  ip address     : 192.86.75.30
  hostname       :
  gateway        :
  subnet         :
  virt bridge    :
  dhcp tag       :
  is static?     : False

Another problem here seems to include some debug output along with the 
Wiki output:

[EMAIL PROTECTED] cobbler]# cobbler report --what=systems --type=trac 
--fields=name,mac_address
[{'name': 'S1', 'mac_address': 'intf0: BB:EE:EE:EE:EE:FF'}]
['name', 'mac_address']
||name||mac_address||
||S1||intf0: BB:EE:EE:EE:EE:FF||

[{'name': 'S1', 'mac_address': 'intf0: BB:EE:EE:EE:EE:FF'}, {'name': 
'drwily.rdu.redhat.com', 'mac_address': 'intf0: BB:EE:EE:EE:EE:FF'}]
['name', 'mac_address']
||name||mac_address||
||S1||intf0: BB:EE:EE:EE:EE:FF||
||drwily.rdu.redhat.com||intf0: BB:EE:EE:EE:EE:FF||

[{'name': 'S1', 'mac_address': 'intf0: BB:EE:EE:EE:EE:FF'}, {'name': 
'drwily.rdu.redhat.com', 'mac_address': 'intf0: BB:EE:EE:EE:EE:FF'}, 
{'name': 'foo', 'mac_address': 'intf2: AA:BB:CC:DD:EE:FE'}]
['name', 'mac_address']
||name||mac_address||
||S1||intf0: BB:EE:EE:EE:EE:FF||
||drwily.rdu.redhat.com||intf0: BB:EE:EE:EE:EE:FF||
||foo||intf2: AA:BB:CC:DD:EE:FE||

[{'name': 'S1', 'mac_address': 'intf0: BB:EE:EE:EE:EE:FF'}, {'name': 
'drwily.rdu.redhat.com', 'mac_address': 'intf0: BB:EE:EE:EE:EE:FF'}, 
{'name': 'foo', 'mac_address': 'intf2: AA:BB:CC:DD:EE:FE'}, {'name': 
'unused_name', 'mac_address': 'intf6: '}]
['name', 'mac_address']
||name||mac_address||
||S1||intf0: BB:EE:EE:EE:EE:FF||
||drwily.rdu.redhat.com||intf0: BB:EE:EE:EE:EE:FF||
||foo||intf2: AA:BB:CC:DD:EE:FE||
||unused_name||intf6: ||

Again there is also the table duplication.

I also see that "cobbler system report --help" doesn't provide the 
extended options, but I am not as concerned with this.

If you can see about addressing the bug above with "fields" and also the 
extra debug output, I can look at applying this.

--Michael


_______________________________________________
cobbler mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/cobbler

Reply via email to