Anderson Silva wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > >> Excellent, this is all applied now and pushed. >> > > >> I made a few minor changes to add some error handling and also be able >> to search better through the field lists. >> > > Changes are always welcome :-) > > >> Some possible improvements would be to add the "--type" syntax to report >> commands invocated with "cobbler system report", so you could do >> "cobbler system report --type=csv --fields=name,mac_address"instead of >> having to remember "cobbler report --what=systems --type=csv >> --fields=name,mac_address". >> > > Yeah, to be honest, I wanted to do that, but I was having a little bit > of an issue on what would be the best way to get that done in the code. > If you have any tips so I can give it a shot it would be greatly > appreciated. >
It's probably going to be a bit interesting as those are a bit special cased. The code to do things like "cobbler system add" are managed by things like cli_system.py, so it's mostly an issue of making sure that the options get added there and that commands.py knows what to do with them. > > That would basically make both work the > >> same. Other neat things would be to add simple fixed-with formatting >> so you could make a easily human (not Wiki) readable output formatted >> with %20s style widths for fields for just including in email or >> skimming over by humans. >> > > Hmm, yeah, I like that, that didn't even cross my mind. > > >> (I also think "--type" probably should named "format" so I'll go ahead >> and take care of that.) >> > > Sounds great. > > >> Thanks! >> > > > I will gladly try to add the 2 new features you are talking about, but > it may be a week or two until I get the chance to sit down with it again. > > > >> --Michael >> _______________________________________________ >> cobbler mailing list >> [email protected] >> https://fedorahosted.org/mailman/listinfo/cobbler >> > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.7 (GNU/Linux) > Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org > > iD8DBQFI0oDzECmX3C4JWKgRAuU1AKCpU0fsRBOyBgIWsPr+Te9QLXs0YACg0SO9 > eeNLiSvgbCJX8NzfpuNd3ic= > =Rb5G > -----END PGP SIGNATURE----- > _______________________________________________ > cobbler mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/cobbler > No rush, what we have here is already very nice to have. --Michael _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
