Jasper Capel wrote: > Jasper Capel wrote: > >> Michael DeHaan wrote: >> >> >>> Right now the interface name could be arbitrary, so it seems it would >>> only depend on the magic to set things up right in %post. Does anyone >>> care to take a shot at cleaning up the "post-network-system-config" >>> snippet on the Wiki now? We should make it account for mutliple >>> interfaces first, add it to %post in the default templates, and then we >>> can teach it about bonding once that is established. >>> >>> >> I spent some time on this yesterday, but unfortunately I won't be able >> to test it this week, so there's probably some typo in it. >> If someone wants to look at it, then great, else I'll try to find the >> time next week. :) >> >> > Tested, removed a few bugs and this works for EL5 now. I don't know if > we'd want to call this one by default, as there's still a default > interface intf0 for systems. This would result in the first interface > being called intf0 instead of eth0, which doesn't make much sense to me. > I think we should change that behaviour first. :) > And I'm not too happy with the name post_network_system_config, so I > renamed it to post_install_network_config, any objections? > > Once this is done, we can look into bonding and vlan support. VLANs > would be fairly easy, so that's a nice next target. > > >> See: >> http://bender.newnewyork.nl/git/gitweb.cgi?p=cobbler/.git;a=commit;h=4746ca96f1950ed98a3068f57755df647ca1a4d7 >> > > http://bender.newnewyork.nl/git/gitweb.cgi?p=cobbler/.git;a=shortlog;h=refs/heads/post-network > >> or: >> git://bender.newnewyork.nl/cobbler (branch: post-network) >> >> Jasper >> > > _______________________________________________ > cobbler mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/cobbler >
I haven't applied this just yet. One thing it needs to do is be aware there is a new "static" interface attribute, so we should use that versus checking to see if the ip is defined or not. The reason for this is that in cobbler you can define the MAC and IP of a system and when using manage_dhcp features it can set up reservations automatically for you in DHCP. This does not mean that you should be using static IP, just that cobbler is maintaing the MAC <-> IP relationship for you. So if you change this, I think this is good to apply. As far as the naming of "intf0" before, the reason for that is before this patch existed, there really was no guaranteed relationship between the interface defined in Cobbler and the interface you would get when you installed it, so I felt is was important to not give anyone assumptions about what was really eth0 or not... it was really an arbitary name only used for internal storage. Now that it's important, yes, the default will be eth0 for all new installs. We /could/ add some code to automatically rename any interfaces so they start with "eth", though it could very well break applications written on top of the Cobbler API. However, it's better to name things consistently. So, fair warning... we'll start calling things "eth0" properly now. Another thing is that this patch doesn't include RPM packaging for the snippet, or inclusion of the snippet into any of the default templates, so once you revise this, I can take care of that if needed. Then we'll also need a fair amount of testing to make sure all the networking is nice and happy. Good feature. --Michael _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
