I bet the testing you did didn't find the code path that was causing me the
issue....

Check out line 165 in the post_install_network_config snippet.

if [ -f "/etc/modprobe.conf" ] && [ $IFNAME ]; then
    grep \$IFNAME /etc/modprobe.conf | sed "s/\$IFNAME/$iname/" >>
/etc/modprobe.conf.cobbler
    grep -v \$IFNAME /etc/modprobe.conf >> /etc/modprobe.conf.new
    rm -f /etc/modprobe.conf
    mv /etc/modprobe.conf.new /etc/modprobe.conf
fi

Particularly:

if [ -f "/etc/modprobe.conf" ] && [ $IFNAME ]; then

That needs to be escaped doesn't it?

ie.

if [ -f "/etc/modprobe.conf" ] && [ \$IFNAME ]; then
    grep \$IFNAME /etc/modprobe.conf | sed "s/\$IFNAME/$iname/" >>
/etc/modprobe.conf.cobbler
    grep -v \$IFNAME /etc/modprobe.conf >> /etc/modprobe.conf.new
    rm -f /etc/modprobe.conf
    mv /etc/modprobe.conf.new /etc/modprobe.conf
fi

bf1f9105 snippets/post_install_network_config (Justin Sherrill 2009-04-09
11:27:56 -0400 165) if [ -f "/etc/modprobe.conf" ] && [ $IFNAME ]; then

Is that right?

I'm surprised this wasn't causing me issues before when i was testing....


On Thu, Jan 21, 2010 at 1:32 PM, Jonathan Sabo <[email protected]> wrote:

> Does is actually generate the output if you assigned it ips?
>
>
> On Thu, Jan 21, 2010 at 1:09 PM, Devan Goodwin <[email protected]> wrote:
>
>> Tested with a kickstart file in /var/lib/cobbler/kickstarts containing:
>>
>> el5-sw.ks:$SNIPPET('post_install_network_config')
>>
>> A cobbler profile getks on that profile contains:
>>
>> # Start post_install_network_config generated code
>> # End post_install_network_config generated code
>>
>> And no occurrences of $SNIPPET.
>>
>> This is with /etc/cobbler/settings:
>> snippetsdir: /var/lib/cobbler/snippets
>> template_remote_kickstarts: 0
>>
>> And the profile object itself using:
>> Kickstart                      : /var/lib/cobbler/kickstarts/el5-sw.ks
>>
>> I can't think of anything that could be causing this for you but,
>> verify the above settings look sane, and maybe the perms as well for
>> starters:
>>
>> $ ll /var/lib/cobbler/snippets/post_install_network_config
>> -rw-r--r-- 1 root root 11898 2009-10-30 15:16
>> /var/lib/cobbler/snippets/post_install_network_config
>>
>> Cheers,
>>
>> Devan
>>
>> On Thu, Jan 21, 2010 at 10:45 AM, Jonathan Sabo <[email protected]>
>> wrote:
>> > Well this is the git master... I would expect it to be broken quite
>> often.
>> > I just want to help fix it so I can keep playing in it.
>> >
>> > On Thu, Jan 21, 2010 at 9:43 AM, Jeff Schroeder <[email protected]>
>> > wrote:
>> >>
>> >> On Thu, Jan 21, 2010 at 6:41 AM, Jonathan Sabo <[email protected]>
>> wrote:
>> >> > Has anyone else or could anyone else who uses this snippet try and
>> >> > render a
>> >> > kickstart and see if it's still working with the git master please?
>> I'm
>> >> > going nuts trying to figure out if it's me or something that's
>> changed
>> >> > that
>> >> > is preventing it from rendering.  I just see the
>> >> > $SNIPPET('post_install_network_config') displayed and it's not in a
>> #raw
>> >> > either....   This was working awhile ago but since I started checking
>> >> > again
>> >> > recently it's not.  If someone could check it out it would be a big
>> >> > help.
>> >>
>> >> Perhaps the remote kickstart support that was recently merged broke
>> >> it? If we keep having problems with that code it should be reverted.
>> >>
>> >> --
>> >> Jeff Schroeder
>> >>
>> >> Don't drink and derive, alcohol and analysis don't mix.
>> >> http://www.digitalprognosis.com
>> >> _______________________________________________
>> >> cobbler mailing list
>> >> [email protected]
>> >> https://fedorahosted.org/mailman/listinfo/cobbler
>> >
>> >
>> > _______________________________________________
>> > cobbler mailing list
>> > [email protected]
>> > https://fedorahosted.org/mailman/listinfo/cobbler
>> >
>> >
>>
>>
>>
>> --
>> Devan Goodwin <[email protected]>
>> http://rm-rf.ca
>> _______________________________________________
>> cobbler mailing list
>> [email protected]
>> https://fedorahosted.org/mailman/listinfo/cobbler
>>
>
>
_______________________________________________
cobbler mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/cobbler

Reply via email to