On Sat, Jan 23, 2010 at 3:50 PM, Jonathan Sabo <[email protected]> wrote:
> I bet the testing you did didn't find the code path that was causing me the
> issue....

You're correct, this is actually unrelated to the remote snippet
templating, looks like it may have been around for awhile.

>
> Check out line 165 in the post_install_network_config snippet.
>
> if [ -f "/etc/modprobe.conf" ] && [ $IFNAME ]; then
>     grep \$IFNAME /etc/modprobe.conf | sed "s/\$IFNAME/$iname/" >>
> /etc/modprobe.conf.cobbler
>     grep -v \$IFNAME /etc/modprobe.conf >> /etc/modprobe.conf.new
>     rm -f /etc/modprobe.conf
>     mv /etc/modprobe.conf.new /etc/modprobe.conf
> fi
>
> Particularly:
>
> if [ -f "/etc/modprobe.conf" ] && [ $IFNAME ]; then
>
> That needs to be escaped doesn't it?
>
> ie.
>
> if [ -f "/etc/modprobe.conf" ] && [ \$IFNAME ]; then
>     grep \$IFNAME /etc/modprobe.conf | sed "s/\$IFNAME/$iname/" >>
> /etc/modprobe.conf.cobbler
>     grep -v \$IFNAME /etc/modprobe.conf >> /etc/modprobe.conf.new
>     rm -f /etc/modprobe.conf
>     mv /etc/modprobe.conf.new /etc/modprobe.conf
> fi
>
> bf1f9105 snippets/post_install_network_config (Justin Sherrill 2009-04-09
> 11:27:56 -0400 165) if [ -f "/etc/modprobe.conf" ] && [ $IFNAME ]; then
>
> Is that right?

Does changing it fix your issue?

I'm not sure but it looks ok to me, I'm a pretty weak shell scripter
but I think that variable can be referenced there just fine, but has
to be escaped below as it's in an actual command.


-- 
Devan Goodwin <[email protected]>
http://rm-rf.ca
_______________________________________________
cobbler mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/cobbler

Reply via email to