On Sun, 7 Mar 2010, Nicolas Palix wrote:
> On Sunday 07 March 2010 04:33:46 Wolfram Sang wrote:
> > ACK. The possibility to add comments is also nice. There, I accidently
> > found a
> > bug or at least, the syntax is not what I expected. I had this excerpt in my
> > spatch-file:
> >
> > + /*
> > * This is
> > * a kernel style multi comment
> > */
> >
> > Note the missing '+' for lines 2-4. Still, the patch contained all of the
> > comment:
> >
> > + /*
> > + * This is
> > + * a kernel style multi comment
> > + */
> >
> > Come to think of it, comments are probably not existant in the abstract
> > layer,
> > so there wouldn't be anything to match against without '+'. Dunno if this
> > should be an error. A warning maybe ("Did you mean '+ <string>'")?
> >
>
> I think this is an unknown feature ! ;)
>
> Should we keep it Julia ?
The problem is that undoubtedly the lexer picks up the whole comment at
once, just looking for */, not for newlines. I think it should be fixed,
because otherwise the user will think he should put + on every line, and
then he will end up with +s in his comments. I will take care of it.
julia
_______________________________________________
Cocci mailing list
[email protected]
http://lists.diku.dk/mailman/listinfo/cocci
(Web access from inside DIKUs LAN only)
