On 9 September 2015 at 20:05, Julia Lawall <[email protected]> wrote: > > > On Wed, 9 Sep 2015, Kieran Bingham wrote: > >> Having now updated using OPAM from earlier, my spatch no longer executes. >> >> Has there been a change, whereby I need to adapt my patch? Or was >> there a fault in the OPAM installation? or does this patch simply not >> run on v.1.0.2? > > You have: > > @ depends on driver @ > identifier driver.probefunc; > identifier client; > identifier id; > @@ > static int probefunc( > struct i2c_client *client, > - const struct i2c_device_id *id > ) > { ... } > > You should move the trailing comma after client onto the - line. > Actually, I'm surprised that it worked in a previous version, but perhaps > Coccinelle got more strict about commas at some point.
Yes, that was it, thank you. And yes, it worked fine on the earlier version, and removed the comma even thought I hadn't asked it to. However, now on this version, Coccinelle is correctly moving those lonely ) up to the probe function line :) Thanks again Kieran _______________________________________________ Cocci mailing list [email protected] https://systeme.lip6.fr/mailman/listinfo/cocci
