Hi Markus, On 9 September 2015 at 21:51, SF Markus Elfring <[email protected]> wrote: >> Spatch available at: https://gist.github.com/kbingham/96477177dd20a72b1c2f >> >> Run it on a linux kernel tree: >> >> with spatch v.1.0.2 I get the following: >> >> kbingham@CookieMonster:/opt/projects/linaro/hikey/kernel$ spatch >> --linux-spacing --sp-file patches/i2c-dt.cocci . --in-place >> init_defs_builtins: /home/kbingham/.opam/system/lib/coccinelle/standard.h >> 1115 1116 >> Fatal error: exception Failure("plus: parse error: >> = File "patches/i2c-dt.cocci", line 66, column 1, charpos = 1115 >> around = ')', whole content = ) >> ") >> kbingham@CookieMonster:/opt/projects/linaro/hikey/kernel$ spatch --version >> spatch version 1.0.2 with Python support and with PCRE support >> >> >> However, re-installing v.1.0.0 executes fine: >> >> kbingham@CookieMonster:/opt/projects/linaro/hikey/kernel$ spatch --version >> spatch version 1.0.0-rc22 with Python support and with PCRE support > > You show another interesting version comparison. > > I suggest to be a bit more careful when you try this tool out installed > in a few directories in parallel. > I would expect that the command calls should reference a directory explicitly > so that potential misunderstanding can be avoided. > > Do you eventually use separate test systems for the development > of semantic patch scripts?
No, I'm simply running on my own personal development laptop. Nothing fancy, I just did an apt-get install coccinelle to retest the patch with the original version, followed by an almost immediate apt-get remove coccinelle once I was certain the patch still worked on that version :) I'm sticking with 1.0.2 now that Julia has highlighted that the fault was mine in not removing the comma :) -- Thanks for your help. Regards Kieran > > Regards, > Markus _______________________________________________ Cocci mailing list [email protected] https://systeme.lip6.fr/mailman/listinfo/cocci
