On Thu, 27 Jun 2019, Markus Elfring wrote:
> >> replacement: already tagged token:
> >
> > You try to add two things one one token, which is not allowed.
>
> How do you think about to clarify why a source file adjustment
> like the following can let my SmPL script succeed in a test configuration?
>
> elfring@Sonne:~/Projekte/Coccinelle/Probe> diff -u megaraid_sas-excerpt1.c
> megaraid_sas-excerpt2.c
> …
> @@ -32,24 +32,7 @@
> goto out_kfree_ioc;
> }
>
> - if (instance->unload == 1) {
> - error = -ENODEV;
> - goto out_kfree_ioc;
> - }
> -
> - if (down_interruptible(&instance->ioctl_sem)) {
> - error = -ERESTARTSYS;
> - goto out_kfree_ioc;
> - }
> -
> - if (megasas_wait_for_adapter_operational(instance)) {
> - error = -ENODEV;
> - goto out_up;
> - }
> -
> - error = megasas_mgmt_fw_ioctl(instance, user_ioc, ioc);
> -out_up:
> - up(&instance->ioctl_sem);
> +// Deleted part
>
> out_kfree_ioc:
> kfree(ioc);
>
>
> Where did the Coccinelle software get the impression that anything
> would be added too often at the end of such a function implementation?
Without the semantic patch and the C source code, I can't answer the
question.
julia_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci
