On Fri, 2020-04-24 at 14:02 +0200, Markus Elfring wrote: > > This patch series aims to improve parsing of attributes in C by > > Coccinelle's C parser. > > How do you think about to use the wording “in C source code by”? > > > > These parsing errors were discovered by running a build of > > Coccinelle's > > Would you like to omit the word “These”? >
Hi Markus, Could you please keep your feedback relevant to the actual patch itself (or the commit messages)? Maybe pull the patches, apply them, run them yourself, see if something breaks? Feedback like this really isn't relevant, unless these minor typos/grammartical errors cause a _lot_ of confusion. > > > Coccinelle currently manages attributes similar to comments, > > Will this aspect trigger further software development considerations? > I don't know. > > > so to explicity state what the attributes are to the C parser, > > a MACROANNOTATION hint was used in Coccinelle's standard.h file. > > I find such information suspicious at first glance. > Additional background information from an update step like > “[RFC PATCH 12/25] parsing_c: cpp_token_c: Introduce MACROANNOTATION > hint” > might make the proposed data processing approach more reasonable. > https://lore.kernel.org/cocci/20200424091801.13871-13-jaskaransingh7654...@gmail.com/ > https://systeme.lip6.fr/pipermail/cocci/2020-April/007217.html > > > > Separate patches will be sent for the above. > > I am curious how the software evolution will be continued here. > Good to know. Cheers, Jaskaran. > Regards, > Markus _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
