>>>> elfring@Sonne:~/Projekte/Linux/next-patched> spatch >>>> --include-headers-for-types >>>> ~/Projekte/Coccinelle/janitor/use_devm_platform_get_and_ioremap_resource3.cocci >>>> drivers/i2c/busses/i2c-rcar.c >>> >>> No, include headers for types doesn't have any impact on how many header >>> files are included. You need options like --all-includes or >>> --recursive-includes. >> >> I still observe that the known patch hunk is not generated even with the >> addition >> of one of these command options. >> https://lore.kernel.org/patchwork/patch/1223734/ >> https://lore.kernel.org/linux-i2c/[email protected]/ >> >> Would I need any extra parameters here? > > Perhaps -I options to help it find the relevant .h file.
I became curious if the software situation can be clarified better. Thus I have tested my transformation approach again with the commit “i2c: altera: use proper variable to hold errno” before the referenced change. @replacement@ expression base, device, resource; @@ -resource = platform_get_resource(device, IORESOURCE_MEM, 0); base = - devm_ioremap_resource(&device->dev, resource) + devm_platform_get_and_ioremap_resource(device, 0, &resource) ; elfring@Sonne:~/Projekte/Linux/next-patched> git checkout edb2c9dd3948738ef030c32b948543e84f4d3f81 && LANG=C make MODE=patch COCCI=~/Projekte/Coccinelle/janitor/use_devm_platform_get_and_ioremap_resource3.cocci M=drivers/i2c/busses V=1 coccicheck Running (4 in parallel): /usr/local/bin/spatch -D patch --very-quiet --cocci-file /home/elfring/Projekte/Coccinelle/janitor/use_devm_platform_get_and_ioremap_resource3.cocci --patch . --dir drivers/i2c/busses -I ./arch/x86/include -I ./arch/x86/include/generated -I ./include -I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi -I ./include/uapi -I ./include/generated/uapi --include ./include/linux/kconfig.h --jobs 4 --chunksize 1 coccicheck failed make: *** [Makefile:1781: coccicheck] Error 255 I can try another customised command out with the shown parameters. elfring@Sonne:~/Projekte/Linux/next-patched> spatch -I ./arch/x86/include -I ./arch/x86/include/generated -I ./include -I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi -I ./include/uapi -I ./include/generated/uapi --include ./include/linux/kconfig.h ~/Projekte/Coccinelle/janitor/use_devm_platform_get_and_ioremap_resource3.cocci drivers/i2c/busses/i2c-rcar.c init_defs_builtins: /usr/local/bin/../lib/coccinelle/standard.h HANDLING: drivers/i2c/busses/i2c-rcar.c May I expect the generation of a patch by the Coccinelle software here? Regards, Markus _______________________________________________ Cocci mailing list [email protected] https://systeme.lip6.fr/mailman/listinfo/cocci
