On Thu, May 24, 2018 at 9:22 AM, Martin Pitt <[email protected]> wrote:
> Marius Vollmer [2018-05-24 9:52 +0300]: > > Can't this be decided by each page / package individually? Some of the > > Cockpit pages use jQuery, some use Mustache, most new ones use > > react-lite. > > It's really awkward to do this, as you would need per-page webpack > aliasing. I've done it a while ago for welder-web [1], and it's not pretty > and > breaks building with plain "webpack" (only works with "make"). > > [1] https://github.com/martinpitt/cockpit/commit/9374d7d2b014854b8 > > > But patternfly-react certainly sounds like something that we should > > consider... > > Agreed, and possibly even get rid of some of our custom components. > > > (Also, I remember there was some drama regarding the React license, has > > that been resolved?) > > I don't remember that, but recently it's MIT: https://github.com/facebook/react/blob/master/LICENSE > That would interest me as well - aside from react-lite being smaller, are > there > any other downsides? > > I can imagine issues around prop-types, since they were "just written" so far, without their actual use. But this is nothing difficult to solve. The react-lite claims to be replacement for React 15.x . Multiple 3rd party dependencies within Cockpit expect React already and they build/behave nicely so far. So I would extrapolate to Cockpit as expect same behavior. React 16 as backward compatible with 15. Anyway, manual testing will be required after the change. Martin > _______________________________________________ > cockpit-devel mailing list -- [email protected] > To unsubscribe send an email to [email protected] > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/cockpit- > [email protected]/message/SIWGWWJU7S7JIBPA6POEN54UFOL5PAD5/ > -- Marek Libra senior software engineer Red Hat Czech <https://www.redhat.com>
_______________________________________________ cockpit-devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]/message/DHJA6P6WDIWAL2B7OO6BUZSK5IECHNJZ/
