On Thu, 2018-05-24 at 09:41 +0200, Kyrylo Gliebov wrote: > I also experienced some problems with using React components, > basically they are not compatible with react-lite. I think if it's > possible to use react on particular page that should be fine enough. > Also, about patternfly-react - it's also relied on react. > And about licensing - indeed it was an issue, but just first URL from Google > [1] > > [1] https://medium.freecodecamp.org/facebook-just-changed-the-license-on-react > -heres-a-2-minute-explanation-why-5878478913b2 > > On Thu, May 24, 2018 at 9:22 AM, Martin Pitt <mar...@piware.de> wrote: > > Marius Vollmer [2018-05-24 9:52 +0300]: > > > Can't this be decided by each page / package individually? Some of the > > > Cockpit pages use jQuery, some use Mustache, most new ones use > > > react-lite. > > > > It's really awkward to do this, as you would need per-page webpack > > aliasing. I've done it a while ago for welder-web [1], and it's not pretty > > and > > breaks building with plain "webpack" (only works with "make"). > > > > [1] https://github.com/martinpitt/cockpit/commit/9374d7d2b014854b8 > > > > > But patternfly-react certainly sounds like something that we should > > > consider... > > > > Agreed, and possibly even get rid of some of our custom components. > > > > > (Also, I remember there was some drama regarding the React license, has > > > that been resolved?) > > > > That would interest me as well - aside from react-lite being smaller, are > > there > > any other downsides? > > > > Martin > > _______________________________________________ > > cockpit-devel mailing list -- cockpit-devel@lists.fedorahosted.org > > To unsubscribe send an email to cockpit-devel-le...@lists.fedorahosted.org > > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > > List Archives: https://lists.fedoraproject.org/archives/list/cockpit-devel@l > > ists.fedorahosted.org/message/SIWGWWJU7S7JIBPA6POEN54UFOL5PAD5/ > > > > -- > Kirill Glebov > Software Engineer > Red Hat Czech > https://github.com/Scribery > _______________________________________________ > cockpit-devel mailing list -- cockpit-devel@lists.fedorahosted.org > To unsubscribe send an email to cockpit-devel-le...@lists.fedorahosted.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/cockpit-devel@lis > ts.fedorahosted.org/message/YI3MAT2DM5MFR6GQ5QMBIDPCHSDP7OT3/
Just a question, Are you guys using patternfly-react already for plugin development? Regards, _______________________________________________ cockpit-devel mailing list -- cockpit-devel@lists.fedorahosted.org To unsubscribe send an email to cockpit-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/cockpit-devel@lists.fedorahosted.org/message/NCOOQWC2PX4PY2K7CTBBT2U5C7OFGSEA/
