Marcus Crafter wrote: > Hi All, > > Hope all is well. > > +1 from me too, although with the example below, I'd use warn() or > something appropriate to indicate that an exceptional situation > has occured (unless that exception really was just for debugging). > > Shouldn't we also wrap our logging statements with tests before > hand ? > > ie. instead of: > > getLogger().debug("some value " + value + ", some other value " + v); > > have: > > if (getLogger().isDebugEnabled()) { > getLogger().debug(.....); > } > > to save logging un-logged text ?
We should *always* do it, it is common practice... when we remember to do it ;-) -- Nicola Ken Barozzi [EMAIL PROTECTED] - verba volant, scripta manent - (discussions get forgotten, just code remains) --------------------------------------------------------------------- --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]