On Thu, 5 Sep 2002, Marcus Crafter wrote:
> Hi All,
>
> Hope all is well.
>
> +1 from me too, although with the example below, I'd use warn() or
> something appropriate to indicate that an exceptional situation
> has occured (unless that exception really was just for debugging).
>
> Shouldn't we also wrap our logging statements with tests before
> hand ?
>
> ie. instead of:
>
> getLogger().debug("some value " + value + ", some other value " + v);
>
> have:
>
> if (getLogger().isDebugEnabled()) {
> getLogger().debug(.....);
> }
This should be normal practice since long ago. LogKit is fast but given
the amount of debug messages Cocoon produces we should use that
coding pattern everywhere.
Giacomo
>
> to save logging un-logged text ?
>
> Cheers,
>
> Marcus
>
> On Thu, Sep 05, 2002 at 03:51:12PM +0200, Carsten Ziegeler wrote:
> > OK, then +1
> >
> > Carsten
> >
> > > -----Original Message-----
> > > From: Nicola Ken Barozzi [mailto:[EMAIL PROTECTED]]
> > > Sent: Thursday, September 05, 2002 3:36 PM
> > > To: [EMAIL PROTECTED]
> > > Subject: Re: [VOTE] Make errors caught only by Cocoon.java
> > >
> > >
> > >
> > > Carsten Ziegeler wrote:
> > > >
> > > >>-----Original Message-----
> > > >>From: Nicola Ken Barozzi [mailto:[EMAIL PROTECTED]]
> > > >>Sent: Thursday, September 05, 2002 3:24 PM
> > > >>To: [EMAIL PROTECTED]
> > > >>Subject: [VOTE] Make errors caught only by Cocoon.java
> > > >>
> > > >>
> > > >>I would really like to see the errors caught ONLY by Cocoon.java, and
> > > >>logged there. It would reduce the problems we are having a LOT.
> > > >>
> > > >>+1
> > > >>
> > > >
> > > > I would like to extend this proposal a little bit by:
> > > >
> > > > "Exceptions are only logged when they are consumed (and not rethrown)".
> > > >
> > > > So, if I write
> > > > try {
> > > > ...
> > > > } catch (Exception e) {
> > > > // ignore this...
> > > > }
> > > >
> > > > this should be logged, perhaps not with level error, but debug.
> > >
> > > +1 Yes, that's it.
> > >
> > > --
> > > Nicola Ken Barozzi [EMAIL PROTECTED]
> > > - verba volant, scripta manent -
> > > (discussions get forgotten, just code remains)
> > > ---------------------------------------------------------------------
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, email: [EMAIL PROTECTED]
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, email: [EMAIL PROTECTED]
> >
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
