> From: Carsten Ziegeler [mailto:[EMAIL PROTECTED]] > Piroumian Konstantin wrote: > > > > > From: Carsten Ziegeler [mailto:[EMAIL PROTECTED]] > > > > > > Hi, > > > > > > I just looked at the InputModule interface and I have some > > > questions/suggestions: > > > > > > a) Package name > > > I think the interface should rather be located in > > > o.a.c.components.modules (or perhaps o.a.c.sitemap) > > > > +1 > > > > > > > > b) Exception handling > > > The methods should not throw an ConfigurationException > because this > > > exception is an "avalon reserved lifecycle exception". > > > ProcessingException would be much better. > > > > +1 > > > > > > > > c) What this optional "modeConf" Parameter? > > > > No idea here. > > > > > > > > d) Is there currently any use for getAttributeValues() ? > > > > For usage in sitemap attribute values only the > getAttribute() method > > has meaning. But input modules are concidered to be used > also in other > > places, e.g. in XSP to obtain modular values (maybe through a > > logicsheet) or in actions. > > > Ah, ok, thanks! > > I have to add > > e) Enumeration vs Iterator > I would like to change getAttributeNames() to return an > Iterator instead of an Enumeration because the Collection API > uses Iterator in favour of Enumeration.
Again +1 for this. This change will make it easier to use JXPath with modules, cause it can access values from standart collections, but not from Enumeration. I suspect that Enumeration was choosed in accordance with the HttpRequest and HttpSession APIs, where getAttributeNames() return Enumeration. -- Konstantin > > > Carsten > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, email: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
