Hmm, is it the responsibility of the InputModule to filter? Or is it rather the calling component which gets information from an InputModule that should filter? And how would you apply this filter, let's say in the sitemap? Or is it a configuration thing?
Carsten > -----Original Message----- > From: www-data [mailto:[EMAIL PROTECTED]]On Behalf Of [EMAIL PROTECTED] > Sent: Tuesday, October 08, 2002 10:59 AM > To: [EMAIL PROTECTED] > Subject: RE: [RT]: InputModules interfaces > > > Quoting Carsten Ziegeler <[EMAIL PROTECTED]>: > > > So, summarizing this, it seems that we agree on changing the InputModule > > interface to > > > > o.a.c.components.modules.InputModule > > { > > Object getAttribute( String name, Map objectModel ) throws > > ProcessingException; > > > > Iterator getAttributeNames( Map objectModel ) throws > > ProcessingException; > > > > Object[] getAttributeValues( String name, Map objectModel ) throws > > ProcessingException; > > } > > > > Everyone happy with this? > > I think we should also provide a security/filtering facility. > > I was always scared to directly incorparate request parameters > into a paths or into the sitemap in general. same applies to the > request logicsheet. people use it to include request parameters > into sql statements - a security nightmare! > > What about having a Filter interface > > interface Filter { > Object filter( Object input ) throws FilterException > } > > interface o.a.c.components.modules.InputModule { > Object getAttribute( String name, Map objectModel, Filter filter) > throws Exception; > Iterator getAttributeNames( Map objectModel ) > throws Exception; > Object[] getAttributeValues( String name, Map objectModel, Filter filter) > throws Exception; > } > > ...but this already asks for Filter chaining, too *sigh* > > Comments? > -- > Torsten > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, email: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]