On 07.Oct.2002 -- 04:50 PM, Carsten Ziegeler wrote:
> Piroumian Konstantin wrote:
> >
> > > From: Carsten Ziegeler [mailto:[EMAIL PROTECTED]]
> > >
> > > Hi,
> > >
> > > I just looked at the InputModule interface and I have some
> > > questions/suggestions:
> > >
> > > a) Package name
> > > I think the interface should rather be located in
> > > o.a.c.components.modules (or perhaps o.a.c.sitemap)
> >
> > +1
And were should the others go? (I.e. OutputModule and database aka
AutoIncrementModule)
> > > b) Exception handling
> > > The methods should not throw an ConfigurationException
> > > because this exception is an "avalon reserved lifecycle
> > > exception". ProcessingException would be much better.
> >
> > +1
see below
> > > c) What this optional "modeConf" Parameter?
This feature is not used with respect to the sitemap usage.
It allows to pass arbitrary configuration data to a module. This could
be a output format, details about the data source or whatever. The
DigestMetaModule for example can be told what algorithm to use, what
salt to use, and whether the result should be encoded as a
string. Basically, the same information that can be passed upon
configuration can be passed at run-time.
Therefore, they throw ConfigurationExceptions. I believe, none
actually does.
> > > d) Is there currently any use for getAttributeValues() ?
> >
> > For usage in sitemap attribute values only the getAttribute() method has
> > meaning. But input modules are concidered to be used also in other places,
> > e.g. in XSP to obtain modular values (maybe through a logicsheet) or in
> > actions.
> >
> Ah, ok, thanks!
>
> I have to add
>
> e) Enumeration vs Iterator
> I would like to change getAttributeNames() to return an Iterator instead
> of an Enumeration because the Collection API uses Iterator in favour of
> Enumeration.
Since this was planned as a painless as possible replacement for the
HTTP request's parameter API I have chosen Enumeration and wrapped an
Iterator. Anyway, I'd be happy both ways.
Chris.
--
C h r i s t i a n H a u l
[EMAIL PROTECTED]
fingerprint: 99B0 1D9D 7919 644A 4837 7D73 FEF9 6856 335A 9E08
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
