Christian Haul wrote: >On 07.Oct.2002 -- 04:50 PM, Carsten Ziegeler wrote: > > >>Piroumian Konstantin wrote: >> >> >>>>From: Carsten Ziegeler [mailto:[EMAIL PROTECTED]] >>>> >>>>Hi, >>>> >>>>I just looked at the InputModule interface and I have some questions/suggestions: >>>> >>>>a) Package name >>>>I think the interface should rather be located in o.a.c.components.modules (or >perhaps o.a.c.sitemap) >>>> >>>> >>>+1 >>> >>> > >And were should the others go? (I.e. OutputModule and database aka >AutoIncrementModule) > > > >>>>b) Exception handling >>>>The methods should not throw an ConfigurationException because this exception is >an "avalon reserved lifecycle exception". ProcessingException would be much better. >>>> >>>> >>>+1 >>> >>> > >see below > > > >>>>c) What this optional "modeConf" Parameter? >>>> >>>> > >This feature is not used with respect to the sitemap usage. > >It allows to pass arbitrary configuration data to a module. This could be a output >format, details about the data source or whatever. The DigestMetaModule for example >can be told what algorithm to use, what salt to use, and whether the result should be >encoded as a string. Basically, the same information that can be passed upon >configuration can be passed at run-time. > >Therefore, they throw configurationExceptions. I believe, none actually does. > >
Is it good to allow passing a configuration at request-time ? This seems like FS to me (Carsten, it's my turn, now ;-) Also, this can hurt performance : extracting configuration data is expensive. And where does this request-time configuration come from ? Is it built from scratch by objects using the module ? This again can hurt perfs. If several different configuration are needed by a module, doesn't this mean in fact that there should be several instances of the module with different configurations declared in cocoon.xconf ? >>>>d) Is there currently any use for getAttributeValues() ? >>>> >>>> >>>For usage in sitemap attribute values only the getAttribute() method has meaning. >But input modules are concidered to be used also in other places, e.g. in XSP to >obtain modular values (maybe through a logicsheet) or in actions. >>> >>> >>> >>Ah, ok, thanks! >> >>I have to add >> >>e) Enumeration vs Iterator >>I would like to change getAttributeNames() to return an Iterator instead of an >Enumeration because the Collection API uses Iterator in favour of Enumeration. >> >> > >Since this was planned as a painless as possible replacement for the >HTTP request's parameter API I have chosen Enumeration and wrapped an Iterator. >Anyway, I'd be happy both ways. > > Chris. > > Sylvain -- Sylvain Wallez Anyware Technologies Apache Cocoon http://www.anyware-tech.com mailto:[EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
