Carsten Ziegeler wrote: >Sylvain Wallez wrote: > > >>>No, I don't agree here. Yes, components are inherited and yes >>> >>> >>views should imho also be inherited, but this is a >>one-way-street. The main sub sitemap gives control to the sub >>sitemap. You can't use components declared in the sub-sitemap in >>the main sitemap etc. >> >> >>> >>> >>> >>> >>I guess there's a misunderstanding here : what I understand in the above >>is that you don't want a pipeline to be partially built in a subsitemap >>and terminated in the parent sitemap. >> >>*I fully agree with this* : a subsitemap should either fully handle the >>request (from generator to serializer) or not handle it at all. >> >> >> >Ok. > > > >>What is proposed is different and is only about giving control back to >>the parent sitemap if a subsitemap did not handle the request, i.e. >>there was no match in the subsitemap. >> >> >> >Ok - thanks for the clarification. > > > >>>>>3) Before you consider implementing this simple sounding >>>>> >>>>> >>change, have a look at all the component manager and source >>handling stuff which takes place when a sub sitemap is invoked - >>it's very difficult to implement your wantet behaviour without >>breaking everything. >> >> >>>>Why is this so difficult ? The environment context is changed >>>> >>>> >>when mounting a subsitemap. Will it be difficult to restore the >>context when "unmounting" a sitemap ? >> >> >>>Yes, I think so - I haven't looked too much into the code but I >>> >>> >>remember that there will be some problems with respect to the >>special lifecycle interfaces handled by the CocoonComponentManager. >> >> >>With the above clarification (no cross-sitemap pipeline building), will >>those problems arise ? >> >> >> >Yes. >
I don't (completely) agree with you on this one. Currently, as you noted, if sub-sitemap does not have error handler, control is moved to the parent sitemap's error handler. At this time, environment should be restored to the state it was before entering sub-sitemap. AFAIR, it works, at least resolution - it happens relative to the parent sitemap. Thus, implementing this feature in the sub-sitemap should be as easy as (2.0.3-speaking) replacing "throw new ResourceNotFoundException" with "return" (+ clearing/disposing of the pipeline built to this moment, to avoid cross-sitemap pipelines). Vadim >>>And sorry, I really think that this idea comes near to FS - but what >>>do others think about this? >>> >>> >>> >>When several people have a good use case for something, then this may >>not be FS but a real need. So let's see what comes out from this >>discussion. >> >> >> >Agreed! > >Carsten > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
