This is great!

We've been talking about doing this for a while now, so your patch is more than welcome!

I haven't had a chance to test it yet (and most likely I won't have one this week), but it's looking great. It would be great if you could add a small Anteater test to test the functionality.

One small observation (even though I hate naming discussions ;) I'd rename 'subrequest' to 'process' since is actually a verb and conveys the meaning of the method. You may also want to add it to the Interpreter interface, in case other flow interpreters come up (Scheme etc.)

Other than that is fine with me.

Thanks for the contribution!

Cheers,
Ovidiu

--
Ovidiu Predescu <[EMAIL PROTECTED]>
http://www.google.com/search?btnI=&q=ovidiu (I'm feeling lucky)

On Tuesday, Feb 25, 2003, at 18:18 US/Pacific, Pier Fumagalli wrote:

I have a small addition to the flow, if you might... It's called
"subRequest"...

Basically, my "problem" is that, sometimes, using the flow, I want to save
the output of a given Cocoon URL to an OutputStream. This might happen
because I have a MimeSerializer which outputs the result of a pipeline in
MIME format (suitable to be transmitted with SMTP), or because I have
something that I want to save to disk, but at the same time, have something
else to deliver to the Client (ok, it's 2 AM and I'm having troubles
explaining what I _need_ to be doing, Stefano, as we talked about it, care
to explain with your extreme conciseness and better english?)


So, roughly, the target of it, is to be able to save the output of a Cocoon
pipeline, to a given outputstream, while, at the same time, serving the flow
to the client... (Ok, this seems clearer)...


I worked on a patch allowing to do this, and before I actually put it in
CVS, I would like to have you folks to review it, as it's a quite big step
in the direction of having multiple outputs for a pipeline, although it's
just few lines of patch...


It is attached, and it's in its very rough format, it just _WORKS_, it isn't
anyhow supposed to be doing much...


Attached, also, there's my little test sub-sitemap, just put it in your
webapp dir under "/test/" and try it out: when you request
"http://localhost:8080/test/"; with your browser, it will display a nice
"Hello world" in your browser, but at the same time, it will save it in
/tmp/test.out...

Let me know... Right now I'm way too confused to make any sense to myself as
well! :-) :-) :-) Tomorrow is another day!


Pier

<patch.txt><test.tar.gz>



Reply via email to