On Wed, Mar 19, 2003 at 09:29:05AM -0500, Vadim Gritsenko wrote: > Jeff Turner wrote: ... > > void setup(SourceResolver resolver, Map objectModel, String src, > > Parameters par) ... > >If there's no objections, I would like to: > >- assert in the Javadoc that 'src' will never be null > > > > Some generators do not require src attribute.
Ah yes.. just as well I asked ;) > >- modify AbstractProcessingPipeline to ensure this, and throw meaningful > > exceptions otherwise. > > > >Currently, leaving out the 'src' attribute causes a typically unhelpful > >Cocoon error message: > > > >java.net.MalformedURLException: Invalid System ID > > > > May be add more helpful message to the AbstractGenerator / > AbstractTransformer? At that level, there isn't enough info to provide a user-friendly error message. I think the best solution is to add a check in the treeprocessor's ReadNodeBuilder. I've now got it displaying: Reader at file:/home/jeff/apache/xml/xml-forrest/build/webapp/sitemap.xmap:135:50 must have a 'src' attribute --Jeff > Vadim >