Github user traflm commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1394#discussion_r161805913
--- Diff: core/conn/odb/src/odb.c ---
@@ -5313,7 +5313,7 @@ static void etabadd(char type, char *run, int id)
}
}
if ( etab[no].type == 'e' ) { /* name & create output file
*/
- for ( i = j = 0; etab[no].tgt[i] && i < sizeof(buff);
i++ ) {
+ for ( i = j = 0; i < sizeof(buff) && etab[no].tgt[i];
i++ ) {
--- End diff --
I don't really get this fully understand.
If i is out of bound for arry tgt, why this change will prevent the tag[i]
to be executed?
---
