[GitHub] trafodion pull request #1394: [TRAFODION-2891] fix the bufoverrun Critical e...

[traflm]

Github user traflm commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1394#discussion_r161806495
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
    @@ -5153,7 +5153,7 @@ odbc_SQLSvc_GetSQLCatalogs_sme_(
                      {
                         ERROR_DESC_def *p_buffer = 
QryCatalogSrvrStmt->sqlError.errorList._buffer;
                         strncpy(RequestError, 
p_buffer->errorText,sizeof(RequestError) -1);
    -                    RequestError[sizeof(RequestError)] = '\0';
    +                    RequestError[sizeof(RequestError) - 1] = '\0';
    --- End diff --
    
    very good catch!


---