Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1464#discussion_r173272707
  
    --- Diff: core/sql/executor/ExExplain.cpp ---
    @@ -1724,9 +1724,9 @@ short ExExplainTcb::getExplainFromRepos(char * qid, 
Lng32 qidLen)
       if (vi->get(0, ptr, len))
         goto label_error2;
       
    -  explainFragLen_ = str_decoded_len(len); // remove trailing null 
terminator
    +  explainFragLen_ = str_decoded_len(len - 1); // remove trailing null 
terminator
    --- End diff --
    
    The JIRA isn't showing  trace fileor debugging info. Can you explain what 
the issue was with passingin 'len' into str_decoded_len ? Seems like the 
explainFragLen_ would have had sufficient length to allocate the explain 
fragment ? Some explanation in the PR or JIRA will help. 


---

Reply via email to