Github user mashengchen commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1464#discussion_r173354026
  
    --- Diff: core/sql/executor/ExExplain.cpp ---
    @@ -1724,9 +1724,9 @@ short ExExplainTcb::getExplainFromRepos(char * qid, 
Lng32 qidLen)
       if (vi->get(0, ptr, len))
         goto label_error2;
       
    -  explainFragLen_ = str_decoded_len(len); // remove trailing null 
terminator
    +  explainFragLen_ = str_decoded_len(len - 1); // remove trailing null 
terminator
    --- End diff --
    
    for the '-1' , i think it should remove trailinng null terminator as the 
comment.
    but last time in anoop 's commit, the '-1' was removed, but the method 
(getExplainFromRepos) is for EXPLAIN_QID,  not for EXPLAIN_STMT (see 
TRAFODION-1755), so i guess he changed the place there is no need to change.


---

Reply via email to