Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1612#discussion_r197893780
  
    --- Diff: core/sql/executor/HdfsClient_JNI.h ---
    @@ -182,13 +186,16 @@ class HdfsClient : public JavaObjectInterface
       HDFS_Client_RetCode    init();
       HDFS_Client_RetCode    hdfsCreate(const char* path, NABoolean overwrite, 
NABoolean compress);
       HDFS_Client_RetCode    hdfsOpen(const char* path, NABoolean compress);
    -  Int32                  hdfsWrite(const char* data, Int64 size, 
HDFS_Client_RetCode &hdfsClientRetcode);
    -  Int32                  hdfsRead(const char* data, Int64 size, 
HDFS_Client_RetCode &hdfsClientRetcode);
    +  Int64                  hdfsSize(HDFS_Client_RetCode &hdfsClientRetcode);
    +  Int32                  hdfsWrite(const char* data, Int64 size, 
HDFS_Client_RetCode &hdfsClientRetcode, int maxChunkSize = 0);
    --- End diff --
    
    maxChunkSize is passed in as Int64 from caller. Here it's declared as int.


---

Reply via email to