Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1612#discussion_r197942792
  
    --- Diff: core/sql/src/main/java/org/trafodion/sql/HDFSClient.java ---
    @@ -359,36 +392,54 @@ int hdfsWrite(byte[] buff) throws IOException
                 logger_.debug("HDFSClient.hdfsWrite() - output stream created" 
);
           }
           outStream_.write(buff);
    +      if (outStream_ instanceof FSDataOutputStream)
    +         ((FSDataOutputStream)outStream_).hsync();
           if (logger_.isDebugEnabled()) 
              logger_.debug("HDFSClient.hdfsWrite() - bytes written " + 
buff.length);
           return buff.length;
         }
    --- End diff --
    
    Ok. I see one placce where hdfsWrite is also called. But int hat case I 
suppose we don't need to the EOD.  Eitherway, what is the difference between 
hdfsWrite and hdfsWriteImmediate ? Also while hdfsWriteImmediate is coccuring , 
can another threadprocess write to the same hdfsfile or is the entire 
hdfsWriteImmediate done under a lock ? 


---

Reply via email to