Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1665#discussion_r206619328
--- Diff: core/sql/executor/ExSequence.cpp ---
@@ -992,23 +992,24 @@ short ExSequenceTcb::work()
break;
}
ex_assert(isUnboundedFollowing(),"");
-
- if ( ! cluster_->flush(&rc_) ) { // flush the buffers
+
+ ComDiagsArea *myDiags = NULL;
+ if (!cluster_->flush(myDiags, heap_)) { // flush the buffers
// if no errors this code path is not visited
- if ( rc_ )
+ if (myDiags)
--- End diff --
It is good to not to treat pointers as boolean variable
---
