Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1665#discussion_r206623640
--- Diff: core/sql/executor/cluster.cpp ---
@@ -1611,6 +1611,49 @@ NABoolean Cluster::initScratch(ExeErrorCode * rc)
return FALSE;
}
+//Wrapper function on flush() to populate diags area.
+//Returns: FALSE - either error, or need to call again
+// TRUE -- flush is done
+NABoolean Cluster::flush(ComDiagsArea *&da, CollHeap *heap) {
+ ExeErrorCode rc = EXE_OK;
+
+ //Flush returning FALSE means either Error or IO_NOT_COMPLETE.
+ //if rc != EXE_OK then it is error.
+ if(!flush(&rc)) {
+ if(rc != EXE_OK) {
+ da = ComDiagsArea::allocate(heap);
--- End diff --
It is possible that caller might pass-in a diags Area with warnings
---
