Github user zellerh commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1721#discussion_r221716066
--- Diff: core/sql/optimizer/NARoutine.cpp ---
@@ -393,6 +411,14 @@ NARoutine::NARoutine(const QualifiedName &name,
char parallelism[5];
CmGetComRoutineParallelismAsLit(routine_desc->routineDesc()->parallelism,
parallelism);
comRoutineParallelism_ = ((char *)parallelism);
+ if (routine_desc->routineDesc()->libBlobHandle)
+ libBlobHandle_ =
NAString(routine_desc->routineDesc()->libBlobHandle,heap);
--- End diff --
Again, a minor comment, but I don't think it is necessary to make an
NAString before assigning a char * to another NAString. Same for lines 417,
419, 421.
---
