Github user zellerh commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1721#discussion_r221723371
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp ---
@@ -9246,26 +9280,44 @@ short CmpSeabaseDDL::executeSeabaseDDL(DDLExpr *
ddlExpr, ExprNode * ddlNode,
// create seabase library
StmtDDLCreateLibrary * createLibraryParseNode =
ddlNode->castToStmtDDLNode()->castToStmtDDLCreateLibrary();
-
- createSeabaseLibrary(createLibraryParseNode, currCatName,
+ if( (CmpCommon::getDefault(USE_LIB_BLOB_STORE) == DF_OFF))
+ createSeabaseLibrary(createLibraryParseNode, currCatName,
currSchName);
+ else
+ {
+
+ createSeabaseLibrary2(createLibraryParseNode, currCatName,
+ currSchName);
+
+
+ }
}
else if (ddlNode->getOperatorType() == DDL_DROP_LIBRARY)
{
// drop seabase library
StmtDDLDropLibrary * dropLibraryParseNode =
ddlNode->castToStmtDDLNode()->castToStmtDDLDropLibrary();
-
- dropSeabaseLibrary(dropLibraryParseNode, currCatName,
currSchName);
+ if( (CmpCommon::getDefault(USE_LIB_BLOB_STORE) == DF_OFF))
+ dropSeabaseLibrary(dropLibraryParseNode, currCatName,
currSchName);
+ else
+ {
+ dropSeabaseLibrary2(dropLibraryParseNode, currCatName,
currSchName);
+ }
}
else if (ddlNode->getOperatorType() == DDL_ALTER_LIBRARY)
{
// create seabase library
StmtDDLAlterLibrary * alterLibraryParseNode =
ddlNode->castToStmtDDLNode()->castToStmtDDLAlterLibrary();
-
- alterSeabaseLibrary(alterLibraryParseNode, currCatName,
- currSchName);
+ if( (CmpCommon::getDefault(USE_LIB_BLOB_STORE) == DF_OFF))
+ alterSeabaseLibrary(alterLibraryParseNode, currCatName,
--- End diff --
Same as above, shouldn't the flavor of the library determine what method to
call? I assume we can't change a library from the old method to a BLOB and vice
versa. To do that, it needs to be dropped and recreated with a different CQD
setting.
---
