Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1688#discussion_r221819747
--- Diff: core/sql/optimizer/RelExpr.h ---
@@ -1439,6 +1459,7 @@ class RelExpr : public ExprNode
enum Flags {
EXPAND_SHORT_ROWS = 0x00000001 // expand short rows when added
columns
,PARENT_IS_ROOT = 0x00000002 // compressed internal format
+ ,HAS_CONNECT_BY = 0x00000004 // compressed internal format
--- End diff --
) typo on the comment.
2) why do we need a bit flag on the RelExpr? Can we just check nullness of
biConnectBy and other data members of this class? I was under the impression
that we did not need bit flags in RelExpr data members in the compiler till be
reached the generator. This could be an incorrect idea.
3) Can any RelExpr have a CONNECT_BY. I am assuming there are several
RelExpr where this is not allowed/supported. We should add binder error for
those that are not caught in the parser, if any.
---
