Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1688#discussion_r221496330
  
    --- Diff: core/sql/parser/ParKeyWords.cpp ---
    @@ -862,7 +863,7 @@ ParKeyWord ParKeyWords::keyWords_[] = {
       ParKeyWord("PREPARE",            TOK_PREPARE,     ANS_|RESWORD_),
       ParKeyWord("PRESERVE",           TOK_PRESERVE,    ANS_|RESWORD_),
       ParKeyWord("PRIMARY",            TOK_PRIMARY,     FIRST_|ANS_|RESWORD_),
    -  ParKeyWord("PRIOR",              IDENTIFIER,      ANS_|RESWORD_),
    +  ParKeyWord("PRIOR",              PRIOR_IDENTIFIER,      ANS_),
    --- End diff --
    
    Could you please explain why this is a PRIOR_IDENTIFIER and not TOK_PRIOR? 
Are we attempting to allow use of PRIOR as an identifier now. It was previously 
not allowed, since it was a RESWORD. Are we trying to have fewer reserved 
words? This would be an admirable goal. Thank you for explaining, this is not a 
defect.


---

Reply via email to