Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1721#discussion_r225014976
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp ---
    @@ -804,13 +1362,15 @@ void CmpSeabaseDDL::createSeabaseRoutine(
           return;
         }
     
    -  // read the library path name from the LIBRARIES metadata table
    -
    +  
    +  // read the library  name from the LIBRARIES metadata table
       char * buf = new(STMTHEAP) char[200];
    -  str_sprintf(buf, "select library_filename from %s.\"%s\".%s"
    + 
    +  str_sprintf(buf, "select library_filename, library_storage from 
%s.\"%s\".%s"
                   " where library_uid = %ld for read uncommitted access",
                   getSystemCatalog(), SEABASE_MD_SCHEMA, SEABASE_LIBRARIES, 
libUID);
    -
    +    
    --- End diff --
    
    Would we ever get here if library_storage did not exist in the LIBRARIES 
table?


---

Reply via email to