robertamarton commented on a change in pull request #1784: [TRAFODION-3268]
[TRAFODION-3269] [TRAFODION-3269] Library manager fixes and LOB alter fix
URL: https://github.com/apache/trafodion/pull/1784#discussion_r252446830
##########
File path: core/sql/cli/Cli.cpp
##########
@@ -9517,20 +9517,37 @@ Lng32 SQLCLI_LOBddlInterface
switch (qType)
{
case LOB_CLI_CREATE:
+ case LOB_CLI_ALTER :
{
- // create lob metadata table
- str_sprintf(query, "create ghost table %s (lobnum smallint not null,
storagetype smallint not null, location varchar(4096) not null, column_name
varchar(256 bytes) character set utf8, primary key (lobnum)) ",lobMDName);
- lobDebugInfo(query,0,__LINE__,lobTrace);
+
+ // create lob metadata table
+ str_sprintf(query, "create ghost table %s (lobnum smallint not null,
storagetype smallint not null, location varchar(4096) not null, column_name
varchar(256 bytes) character set utf8, primary key (lobnum)) ",lobMDName);
+ lobDebugInfo(query,0,__LINE__,lobTrace);
- // set parserflags to allow ghost table
- currContext.setSqlParserFlags(0x1);
-
- cliRC = cliInterface->executeImmediate(query);
- currContext.resetSqlParserFlags(0x1);
+ // set parserflags to allow ghost table
+ currContext.setSqlParserFlags(0x1);
- if (cliRC < 0)
- goto error_return;
+ cliRC = cliInterface->executeImmediate(query);
+ currContext.resetSqlParserFlags(0x1);
+ if (cliRC < 0)
+ {
+ ComDiagsArea *tempDiags =
ComDiagsArea::allocate(currContext.exHeap());
Review comment:
Do you have to deallocate tempDiags?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
