robertamarton commented on a change in pull request #1784: [TRAFODION-3268]
[TRAFODION-3269] [TRAFODION-3269] Library manager fixes and LOB alter fix
URL: https://github.com/apache/trafodion/pull/1784#discussion_r252446844
##########
File path: core/sql/executor/ExUdr.cpp
##########
@@ -809,20 +809,17 @@ Int32 ExUdrTcb::fixup()
else
libOrJarName = myTdb().getContainerName();
Int32 err = 0;
- if(ComGenerateUdrCachedLibName(libOrJarName.data(),
+ if(err=ComGenerateUdrCachedLibName(libOrJarName.data(),
myTdb().getLibraryRedefTime(),
myTdb().getLibrarySchName(),
dummyUser,
cachedLibName, cachedLibPath))
{
- NAString cachedFullName = cachedLibPath+"/"+cachedLibName;
+
char errString[200];
NAString errNAString;
- sprintf(errString , "Error %d creating directory :",err);
- errNAString = errString;
- errNAString += cachedFullName;
-
-
+ sprintf(errString , "Error %d creating directory %s :",err,
cachedLibPath.data());
+ errNAString = errString;
Review comment:
Can cachedLibPath be longer than 200 characters? Will errString size be
long enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
