DaveBirdsall commented on a change in pull request #1845: [TRAFODION-3263] and
other misc fixes for lob locking and refactoring
URL: https://github.com/apache/trafodion/pull/1845#discussion_r300064086
##########
File path: core/sql/cli/Cli.cpp
##########
@@ -8554,17 +8558,34 @@ Lng32 SQLCLI_LOBcliInterface
case LOB_CLI_INSERT:
{
// insert into lob descriptor handle table
- str_sprintf(query, "select syskey from (insert into table(ghost table
%s) values (%ld, 1, %ld)) x",
- lobDescHandleName, descPartnKey, (dataLen ? *dataLen : 0));
+ str_sprintf(query, "select syskey from (insert into table(ghost table
%s) values (%ld, 1, %ld)) x",
+ lobDescHandleName, descPartnKey, (dataLen ? *dataLen : 0));
+ /*str_sprintf(query, "select syskey from (insert into
table(ghost table cast(? as varchar(1024)) values (cast(? as largeint), 1,
cast(? as largeint))) x");*/
+
Review comment:
Any reason for keeping the old code around in comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
