DaveBirdsall commented on a change in pull request #1845: [TRAFODION-3263] and
other misc fixes for lob locking and refactoring
URL: https://github.com/apache/trafodion/pull/1845#discussion_r300064326
##########
File path: core/sql/cli/Cli.cpp
##########
@@ -8554,17 +8558,34 @@ Lng32 SQLCLI_LOBcliInterface
case LOB_CLI_INSERT:
{
// insert into lob descriptor handle table
- str_sprintf(query, "select syskey from (insert into table(ghost table
%s) values (%ld, 1, %ld)) x",
- lobDescHandleName, descPartnKey, (dataLen ? *dataLen : 0));
+ str_sprintf(query, "select syskey from (insert into table(ghost table
%s) values (%ld, 1, %ld)) x",
+ lobDescHandleName, descPartnKey, (dataLen ? *dataLen : 0));
+ /*str_sprintf(query, "select syskey from (insert into
table(ghost table cast(? as varchar(1024)) values (cast(? as largeint), 1,
cast(? as largeint))) x");*/
+
lobDebugInfo(query,0,__LINE__,lobTrace);
// set parserflags to allow ghost table
currContext.setSqlParserFlags(0x1);
- Int64 descSyskey = 0;
+ Int64 descSyskey = 0;
Lng32 len = 0;
- cliRC = cliInterface->executeImmediate(query,
+ /*
+ strcpy(stmtName,"INS1");
+ cliRC =
cliInterface->executeImmediatePrepare(query,NULL,0,&rowsAffected,FALSE,stmtName);
+ if (cliRC < 0)
+ goto error_return;
+ char *inputValues = new (currContext.exHeap()) char[sizeof(Int32) +
strlen(lobDescHandleName) + sizeof(Int64)*2];
+ *(Int32 *)inputValues= strlen(lobDescHandleName);
+
memcpy(&inputValues[sizeof(Int32)],lobDescHandleName,strlen(lobDescHandleName));
+
+ inputValues[sizeof(Int32) + strlen(lobDescHandleName)] = descPartnKey;
+ inputValues[sizeof(Int32) + strlen(lobDescHandleName)+sizeof(Int64)] =
(dataLen ? *dataLen : 0);
+ inputValuesLen = sizeof(Int32) +
strlen(lobDescHandleName)+sizeof(Int64)*2;
+ cliRC = cliInterface->clearExecFetchCloseOpt((char
*)inputValues,inputValuesLen,(char*)&descSyskey,&len, &rowsAffected);
+ */
Review comment:
Why was this block of commented-out code added?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
