Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/30#discussion_r34823666
--- Diff: core/sql/ustat/hs_globals.h ---
@@ -1889,6 +1897,8 @@ class HSGlobalsClass : public NABasicObject
Int64 stmtStartTime;
NABoolean jitLogOn;
+ static THREAD_P NABoolean performISForMC_;
--- End diff --
I'm wondering why this is a static variable. The constructor always
initializes it to FALSE, so if there is more than one HSGlobalsClass object
created by a thread, one of the constructor calls will trash any value that was
set by method calls on the other object. Perhaps only one HSGlobalsClass object
is created per thread, but if that is the case, again I wonder why it is a
static variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
