Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/30#discussion_r34824041
  
    --- Diff: core/sql/ustat/hs_globals.cpp ---
    @@ -4896,7 +4900,7 @@ void 
HSGlobalsClass::getMemoryRequirementsForOneGroup(HSColGroupStruct* group, I
     // on the amount of memory allocated to hold their values.
     //
     // Note: row count may be adjusted up if DP2 sampling and heavy amount of 
varchars.
    -Int64 HSGlobalsClass::getInternalSortMemoryRequirements()
    +Int64 HSGlobalsClass::getInternalSortMemoryRequirements(NABoolean 
performISForMC)
    --- End diff --
    
    Why is a parameter used here? Is this a "what if" call that sets the static 
global variable later?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to