Github user traflm commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/257#discussion_r49534657
--- Diff: core/sql/sqlcomp/nadefaults.cpp ---
@@ -1958,6 +1958,7 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS, "OFF"),
DDkwd__(HIVE_DEFAULT_CHARSET, (char *)SQLCHARSETSTRING_UTF8),
DD_____(HIVE_DEFAULT_SCHEMA, "HIVE"),
+ DD_____(HIVE_FILE_CHARSET, (char *)SQLCHARSETSTRING_UTF8),
--- End diff --
yes, Hans is correct. The current logic cannot work well if in some cases,
HIVE_DEFAULT_CHARSET is not UTF8. It is better to change HIVE_FILE_CHARSET as
empty and change the checking logic in the synthType.cpp logic accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
