Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/257#discussion_r51158775
--- Diff: core/sql/generator/GenRelScan.cpp ---
@@ -214,22 +215,32 @@ int HbaseAccess::createAsciiColAndCastExpr(Generator
* generator,
((CharType*)newGivenType)->setUpshifted(FALSE);
}
+ if (newGivenType->getTypeQualifier() == NA_CHARACTER_TYPE &&
+ CmpCommon::getDefaultString(HIVE_FILE_CHARSET) == "GBK")
--- End diff --
It might be good to add a check here that HIVE_FILE_CHARSET must be an
empty string or equal to HIVE_DEFAULT_CHARSET or GBK. In all other cases we
would probably not do what the user expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
